Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #39115 #39074 #39630

Merged
merged 2 commits into from
Jan 9, 2017
Merged

Automated cherry pick of #39115 #39074 #39630

merged 2 commits into from
Jan 9, 2017

Conversation

Random-Liu
Copy link
Member

Cherry pick of #39115 #39074 on release-1.5.

#39115: Do not use sudo when untar node e2e tar ball.
#39074: Support set user with --ssh-user flag when running remote

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 9, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jan 9, 2017
@Random-Liu Random-Liu force-pushed the automated-cherry-pick-of-#39115-#39074-upstream-release-1.5 branch from ac9bc5c to 1328d03 Compare January 9, 2017 18:56
@Random-Liu Random-Liu added this to the v1.5 milestone Jan 9, 2017
@Random-Liu Random-Liu added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jan 9, 2017
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit ac9bc5c2587c1c487e76271ad4957f5db9662050. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Random-Liu Random-Liu assigned krzyzacy and saad-ali and unassigned timstclair Jan 9, 2017
@k8s-ci-robot
Copy link
Contributor

Jenkins kops AWS e2e failed for commit ac9bc5c2587c1c487e76271ad4957f5db9662050. Full PR test history.

The magic incantation to run this job again is @k8s-bot kops aws e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

Jenkins CRI GCE Node e2e failed for commit ac9bc5c2587c1c487e76271ad4957f5db9662050. Full PR test history.

The magic incantation to run this job again is @k8s-bot cri node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Random-Liu
Copy link
Member Author

Random-Liu commented Jan 9, 2017 •
edited

Fixes #39597.
/cc @saad-ali @krzyzacy

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit ac9bc5c2587c1c487e76271ad4957f5db9662050. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jan 9, 2017
@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit ac9bc5c2587c1c487e76271ad4957f5db9662050. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit ac9bc5c2587c1c487e76271ad4957f5db9662050. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@krzyzacy
Copy link
Member

krzyzacy commented Jan 9, 2017

eh what's going on with @k8s-ci-robot ?

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit ac9bc5c2587c1c487e76271ad4957f5db9662050. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@krzyzacy
Copy link
Member

krzyzacy commented Jan 9, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2017
@Random-Liu
Copy link
Member Author

@krzyzacy I updated the PR once, I think these are previous test result. We can wait for the new result.

@krzyzacy
Copy link
Member

krzyzacy commented Jan 9, 2017

ref for kubernetes/test-infra#1348

@Random-Liu
Copy link
Member Author

Both node e2e and cri node e2e passed. I think the PR works!

@saad-ali saad-ali added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jan 9, 2017
@saad-ali
Copy link
Member

saad-ali commented Jan 9, 2017

Both node e2e and cri node e2e passed. I think the PR works!

Thanks for the fix @Random-Liu!

@saad-ali
Copy link
Member

saad-ali commented Jan 9, 2017

Setting P0 priority since the issue this fixes is blocking merges of cherry picks to the 1.5 branch.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jan 9, 2017
@Random-Liu
Copy link
Member Author

@saad-ali Could you add the cherrypick-approved label?

@krzyzacy
Copy link
Member

krzyzacy commented Jan 9, 2017

whoops.. looks like the bot needs a different label

@saad-ali saad-ali added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 9, 2017
@saad-ali
Copy link
Member

saad-ali commented Jan 9, 2017

Added the wrong approved :) Fixed

@saad-ali saad-ali removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jan 9, 2017
@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit 1328d03. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@krzyzacy
Copy link
Member

krzyzacy commented Jan 9, 2017

failed to create workspace directory: command [ssh -i /root/.ssh/google_compute_engine -o UserKnownHostsFile=/dev/null -o IdentitiesOnly=yes -o CheckHostIP=no -o StrictHostKeyChecking=no -o ServerAliveInterval=30 -o LogLevel=ERROR jenkins@35.184.32.57 -- mkdir /tmp/node-e2e-20170109T142431] failed with error: exit status 255 output: ""

woooo.... why no output...

@saad-ali
Copy link
Member

saad-ali commented Jan 9, 2017

@k8s-bot node e2e test this

@saad-ali
Copy link
Member

saad-ali commented Jan 9, 2017

Submit queue is blocked. Merging this manually to unblock merges to 1.5 branch.

All checks have passed
14 successful checks

@saad-ali saad-ali merged commit 8e68207 into kubernetes:release-1.5 Jan 9, 2017
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@Random-Liu Random-Liu deleted the automated-cherry-pick-of-#39115-#39074-upstream-release-1.5 branch January 9, 2017 23:55
@dchen1107 dchen1107 mentioned this pull request Jan 9, 2017
Merged
@saad-ali saad-ali mentioned this pull request Jan 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@krzyzacy krzyzacy

@saad-ali saad-ali

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Random-Liu @k8s-reviewable @k8s-ci-robot @krzyzacy @saad-ali @k8s-cherrypick-bot @timstclair @k8s-github-robot